[1] The contents of this string (landscape/monitor/tests/test_processorinfo.py) have tabs and a trailing whitespace:
+ ARMv7 = """ Not sure if it's important to preserve that or not... This is not really a review comment, but qemu supports ARM (as well as PPC and Sparc), and it would be nice to set up Ubuntu images (and a means of installing these images) for optional thorough testing purposes, given the lack of buildbot (and slaves). It'd be sweet to run 4 qemu/kvm clients (for the 4 supported architectures) against a landscape server and take them through their paces... [2] This is totally a personal preference sort of thing, but if it were me, I probably would have used a regex with groups for (word) white- space:white-space(data)optional-white-space, thus safe-guarding against possible data-mangling if a colon were to ever appear in the data, I also like referencing from matches groups more than list data (e.g., parts[1]). [3] When you implement Jamu's suggestion, be sure to add a test (that would fail for the current implementation). +1 with Jamu's comments addressed (mine are optional) ** Tags removed: review -- Support for ARM architecture https://bugs.launchpad.net/bugs/317285 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
