- is this correct?
Maintainer: Ubuntu Modem Manager Team <[email protected]>
- copyright file says "II. PACKAGING" but there's no "I. "
- debian/patches/ftbfs_hardy_glib_include_signal_h.patch can be dropped, as 
src/main.c includes signal.h unconditionally now; besides it wasn't applied 
because there is no series, an empty series should be added at the same time
- debian/compat file is missing, debhelper compat level isn't set apparently
- packages uses CDBS but computes plenty of things which CDBS already provides:
DEB_SOURCE := $(shell dpkg-parsechangelog | grep Source: | sed -e 's/Source: 
//')
DEB_VERSION := $(shell dpkg-parsechangelog | grep Version: | sed -e 's/Version: 
//')
DEB_UPSTREAM_VERSION := $(shell echo $(DEB_VERSION) | sed -e 's/-[^-]*$$//')
DEB_MAJOR_VERSION := $(shell echo $(DEB_UPSTREAM_VERSION) | sed -e 's/git.*//')
- build-dep on automake should be automake >= 1.10 (and it would be nice to 
encode < 1.12~ too since the build only supports 1.10 and 1.11)
- DEB_CONFIGURE_EXTRA_FLAGS += $(NULL) is a bit useless  ;-)
- the pre-build touch aclocal.m4 looks a bit suspicious to me, I'm not sure why 
there should be any timestamp issue here
- nobody is subscribed to bugmail

I'd like to see some of the packaging issues addressed, but otherwise
it's good to go

-- 
[MIR] modemmanager
https://bugs.launchpad.net/bugs/410259
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to