I was conscious of the code duplication between hdparm_apm_option_for_disk() and the udev rule. The challenge is that pm-utils is looking to be given one specific option for the device, and udev wants to apply all the options specified in /etc/hdparm.conf, so I felt implementing a duplicate, stripped-down parser would be the lesser evil here for a FFe.
Since the code duplication is ok, I think we should leave this as-is in /usr/ilb for now; it's going to be an API change regardless if we refactor the code later, so I don't think there's any benefit to placing the file in /lib yet. The code defaults to 254 because it's implementing our policy, which up to now was hard-coded in pm-utils (and acpi-support before that). The manpage doesn't say that 255 is a default, it just presents 255 as an example value; probably a bad example since this apm value has a special meaning, but I think that's out of scope for the FFe. Will add a comment to hdparm_apm_option_for_disk() as suggested. -- pm-utils doesn't reload hdparm.conf after a suspend https://bugs.launchpad.net/bugs/238555 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
