Oh, here's one other comment I had:

If no string is matched and substituted, really that's an error, but sed
does not return any special status to indicate this, and currently
redboot-cmdline doesn't detect or report this, though it should just
result in the old command line being written back again so although the
result won't be what the user expects, the system shouldn't be broken
(?)  If the string is substituted multiple times, that might be
considered an error too. However, I think these things shouldn't occur
unless the RedBoot commands were garbage in the first place.

GNU sed can return a programmable status value via the q or Q commands
(as in s/this/that/; t1; q1; :1) - this might be useful, but this
behaviour is not in POSIX and might not work with busybox sed for
example (I've not tried it); so if detecting this case it might be safer
to use grep explicitly.

-- 
redboot-cmdline can not cope with slashes in cmdline
https://bugs.launchpad.net/bugs/462605
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to