kdelibs: - packaging looks good now - in this kpty.cpp patch snippet gotpty: + return _attachPty(d->masterFd); + + return true; +}
the second return is unnecessary and looks confusing, but it's just cosmetical. - will the code alter the default behaviour in the function where this code snippet is from? _attachPty() does some additional things that the original function didn't do, in particular either grantpt(d->masterFd); or ::close(d->masterFd); this looks like if it would alter the current behaviour of unrelated programs. Can you elaborate about this, please (preferably in the changelog)? - are the kdwarnings displayed by default? this looks like left-over debugging stuff -- SRU: updates necessary for Kubuntu Upgrade Tool in Edgy https://launchpad.net/bugs/84717 -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
