Hi Dave and linuxcentre,
Thanks for filing this SRU request. A few comments:
(1) The patch's fixes, as detailed in debian/changelog and linuxcentre's
comments #4 and #5 do not match this bug's original description. These two
should be made consistent for SRU verification purposes. Reading over the
fixes, I agree that ALL of these deserve being in the SRU, so I suggest just
updating the bug description with all the bugs being fixed.
(2) Minor quibbles: No need to mention MaintainerSpec updating in the
SRU changelog. Users pulling this update probably don't care.
(3) karmic --> karmic-proposed in changelog
(4) "Closes (LP: #12345)" is nonstandard. Just "(LP: #12345)" for
closing Launchpad bugs, and "Closes: #12345" for Debian bugs.
(5) Version number should be 2.41-1ubuntu0.1
Please address these issues, and I'd be happy to look at this SRU again!
Thanks,
John
** Also affects: get-iplayer (Ubuntu Karmic)
Importance: Undecided
Status: New
--
get_iplayer cannot download iphone mode in this older version
https://bugs.launchpad.net/bugs/505433
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
