Some small suggestions on the shell script:
- mktemp /tmp/"$me-XXXXXX" => mktemp -t "$me-XXXXXXXX"
- instead of echo -n + final echo, why not just accumulate defines in a string 
which you output?  e.g. DEFINES="", DEFINES="$DEFINES -DFOO" and echo "CFLAGS 
+= $DEFINES"
- you could eval this from make instead of generating an intermediate make, but 
that's a bit harder to read I guess (avoids the chicken and egg between the 
include being missing before it's generated though)
- I personally do the tests directly in make, but you could also consider 
autoconf itself I guess

Thanks!

-- 
[armel] fio fails to build with ARMv7 optimizations
https://bugs.launchpad.net/bugs/532722
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to