Thanks for testing! I also committed that patch upstream now.

Subscribing ubuntu-sru then.

IMPACT: Using the eject button on CD-ROM drives leaves a stale
/media/cdrom mount around if the CD drive is in /etc/fstab (as the
Ubuntu installer set up until jaunty or karmic).

FIX: 
 - upstream: 
http://cgit.freedesktop.org/udisks/commit/?id=3e14a2ff841b477f269a4e95ee19a11bceb2a354
 - lucid: uploaded to unapproved queue, will go in after beta-1
 - karmic: patch logically applies, but needs to be ported for different code 
formatting and devicekit-disks vs. udisks names

REGRESSION POTENTIAL:
 - This patch applies to any media in /etc/fstab, not just to CD-ROMs. So if 
there previously was an assumption that mounts would stay around even with the 
device media disappearing underneath, this assumption would now be broken. This 
is fairly academic, though, IMHO.
 - The patch just adds another OR condition, thus does not affect behaviour if 
CD drives (or drives in general) are not in /etc/fstab.

TEST CASE:
 - Add CD-ROM to /etc/fstab:

   /dev/sr0  /cdrom udf,iso9660 defaults,user 0 0

 - Insert CD, let it automount

 - Press eject button on the drive
    * on karmic: /cdrom mount stays around
    * with fix: /cdrom mount disappears (gets umount -l /cdrom from 
devicekit-disks)

Uploaded package to karmic-proposed, I need another ubuntu-sru member to
review.

-- 
CD eject but not unmount when using drive button and CD is in fstab
https://bugs.launchpad.net/bugs/476654
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to