Hi Fabrice,
> Hi Jonathan,
>
> Some comments on your last debdiff:
> - debian/control: Do not add a second patch system: the package already has
> one (simple-patchsys), so please use them, even if you have to 'convert' the
> actual patches.
I've just dropped the dpatch dependency. Patches don't seem to need
conversion...
I've uninstalled dpatch and done a quick bzr builddeb, so it seems OK.
[...]
Trying patch debian/patches/config-write-sync.patch at level 1 ... success.
Trying patch debian/patches/ubuntu-keyring.patch at level 1 ... success.
> - The Vcs-Bzr tag is not of any use as the full packaging stuff is in Debian.
> I would drop it.
OK, dropped.
> - Debian/copyright: I would avoid changing Debian by Ubuntu in this file. So
> keep it as-is from Debian.
I agree this is overkill, but it was a reminder from last package and I didn't
drop it as I didn't know which attitude was right.
> - debian/patches/00list: this file is not used by simple-patchsys, so it can
> be dropped
Done.
> Apart from that, it looks good.
Cool, I'm glad to have managed to do a good job with your help.
Bzr branch updated.
Just some questions now:
- why is the changelog being merged with Debian's (or why it wasn't before?)
Seems cool but makes a big debdiff.
- Would this update make it to lucid (10.04.1)? It involves quite a lot of
bug fixes.
- What about the remaining patches? Send Upstream? It's strange to have them
Ubuntu specific.
- This update don't seem to close bugs (appart that one) but they are
numerous and some seem quite outdated. What is the attitude to adopt?
New debdiff attached (I hope it will be correctly handled by launchpad).
Thanks a lot for your work
Jonathan
** Patch added: "new debdiff against squeeze"
http://launchpadlibrarian.net/49206955/diff-against-squeeze.diff
--
Please merge gajim 0.13.4-1 from debian testing
https://bugs.launchpad.net/bugs/506049
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
