So this looks mostly OK.  I was worried a bit back, because it had been
removed from Debian testing due to python 2.6 incompatibility, but it's
back now.  Pretty simple packaging and well maintained in both Ubuntu
and Debian.

But there are lots of bugs both upstream and several in Ubuntu,
including several crashers.  And some iffy code (running system() with
unquoted filenames, but not in a way that seemed exploitable -- not on
filenames given on the command line for example).

I'd be more comfortable if the test suite it seems to carry was enabled.
If it was, I would approve.  I enabled it by passing -DENABLE_TESTS=ON
in debian/rules, but I wasn't sure how to actually run them with cmake.
I'm an autotools man.

Another nice thing would be to file our remaining delta with Debian as
patches, so we can eventually sync with them, reducing maintenance
burden yet more.  We're very close now that they support python 2.6.

** Changed in: avogadro (Ubuntu)
       Status: New => Incomplete

** Changed in: avogadro (Ubuntu)
     Assignee: Michael Terry (mterry) => (unassigned)

-- 
[MIR] avogadro
https://bugs.launchpad.net/bugs/592640
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to