On Tuesday 19 Oct 2010 01:56:38 Faustus wrote:
> First,
> 
> /usr/share/laptop-mode-tools/modules/ethernet:                if ! [ -z
> $path ]; then
> /usr/share/laptop-mode-tools/modules/ethernet:                if ! [ -z
> $dev_path ] && [ -f $dev_path/enable ]; then
> 
> are confusing without the quotes around the variable given to -z (but it
> still works in Bash).
>

So does it not work with dash ?
laptop-mode-tools uses dash and I haven't seen this bug report. In case you 
see problems when run with dash, please report.
 
> Second, in the ETHERNET devices loop, if $path is empty, previous value
> for $dev_path will be used (redundantly operating on the device).

Thank you. I have fixed this in the upstream branch. Will be part of the next 
(1.56) release.


Ritesh

-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

-- 
ethernet module has a control flow bug
https://bugs.launchpad.net/bugs/662924
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to