Lorenzo,

Thanks for your debdiff! Overall the patch looks ok except for:
* you have this in the changelog, but it is already applied upstream: "Replaced 
ipt_DSCP.h by xpt_DSCP.h in ipt_ECN.h and ipt_echn.h (LP: #600195)"
* you dropped the --reap patch. Everything wasn't actually added in 1.4.8 and 
the patch for 1.4.4 had to be updated
* the changes for 0901-build-libipq_pic.a.patch weren't right for this build. 
We need to use 'la' now.
* when making changes to debian/*.install files, I like to add them to the end 
of the file where it makes sense, that way it is clearer what came from Debian 
and what came from Ubuntu (eg, the howtos were prepended to iptables.install 
and iptables-dev.install, but it is preferred to be appended

I had already had a merge prepared for 1.4.9 when you filed the bug that
had these changes along with several other packaging updates for making
the Ubuntu delta easier to maintain. I will take your debdiff and make
my changes with my next upload (giving you credit for your work of
course). Unfortunately, iptables must now be built with libnfnetlink-
dev, but this is in universe and must be promoted before upload.

Tested local build and it works fine. I enabled ufw and rebooted and the
firewall is still on. I also ran the root tests in ufw which exercises
various parts of iptables (though not all by any means). I also verified
the html documentation all works right. The source package (without
changes) is here: http://people.canonical.com/~jamie/iptables/.

** Also affects: libnfnetlink (Ubuntu)
   Importance: Undecided
       Status: New

-- 
Please merge iptables 1.4.10-1 (main) from debian unstable (main)
https://bugs.launchpad.net/bugs/671652
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to