I'd like to see a few things fixed up before this goes into main:
- build-time FORTIFY_SOURCE warnings should be appropriately fixed, for example:
sftp.c: In function 'kbd_callback':
sftp.c:78: warning: ignoring return value of 'fgets', declared with attribute
warn_unused_result
sftp.c: In function 'main':
sftp.c:259: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
- I'd like to see the upstream tests actually run at build-time
Beyond that, it looks fine to me.
** Changed in: libssh2 (Ubuntu)
Status: New => Incomplete
** Changed in: libssh2 (Ubuntu)
Assignee: Kees Cook (kees) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/681423
Title:
[MIR] libssh2
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
