@Seth I tested the error path and entry->skb = NULL turns out to be absolutely needed before returning, otherwise there will also be a hard panic. Moving padding to the start looks good to me. The only thing changing the skb length afterwards is guaranteed to do so by multiples of 32 bits. Maybe add a full stop at the end of message while you're at it and maybe even an unlikely() if that looks right to you. The other files in the rt2x00 project seem to use it a lot and it does make it nicely explicit that we're not expecting it.
Thanks, Wolfgang -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/659143 Title: 64bit-only: regression: kernels >=2.6.34: rt2800pci: load firmware Error with ralink [1814:0781] -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
