Public bug reported:

Binary package hint: ubiquity

Ubuntu release: natty daily from 20110301
Ubiquity version: 2.5.21, revno 392
 
It used to be that we could get preseeded, automated installations to reboot 
when finished by setting:

ubiquity ubiquity/reboot boolean true

However, this stopped working recently. I found out that we now need to
set two values in order for the system to reboot when finished:

ubiquity ubiquity/reboot boolean true
ubiquity ubiquity/poweroff boolean true

I tracked down the change to Ubiquity 2.5.13 where code was added to
ubiquity/frontend/gtk_ui.py and ubiquity/frontend/kde_ui.py,  to fix bug
#690726. Starting in that version, for the system to *either* reboot or
shutdown (the latter via ubiquity/poweroff), *both* of these options
have to be set to true.

The code expresses this but it seems to me that it's incorrect, and one
should be able to get a reboot or shutdown by setting only the actual,
desired value. What's more, if they are both set, ubiquity/reboot takes
precedence because it comes first in the code, meaning that the section
of code that issues a shutdown will never get called.

The problem line (610 on gtk_ui.py, 483 on kde_ui.py) says:

elif not self.get_reboot_seen() or not self.get_shutdown_seen():

should be:

elif not self.get_reboot_seen() and not self.get_shutdown_seen():

or (I think it's clearer):

elif not (self.get_reboot_seen() or self.get_shutdown_seen()):

The attached patch implements the proposed changes.

** Affects: ubiquity (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: natty patch pcert

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/727416

Title:
  Preseeded installation doesn't reboot unless ubiquity/poweroff is also
  set

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to