Looks much better; some comments:
* the check_subarch tests are a bit weird:
+>------>-------case $subarch in.
+>------>------->-------"imx51")
+>------>------->------->-------check_subarch "imx51"
+>------>------->-------;;
+>------>------->-------*)
+>------>------->------->-------check_subarch "mx51"
+>------>------->-------;;
+>------>-------esac
since check_subarch checks subarch against that value, the first one is 
basically if imx51 == imx51, and the second one will randomly fail.

There is simply no code showing how to allow multiple kernels for a single 
board, so either don't call check_subarch, or implement your own test + error 
message.  You could abuse this a bit with:
case $subarch in
imx51|mx51)
  :
;;
*)
  # not actually the real expected kfile subarch, but will raise a sensible 
error
  check_subarch "mx51 or imx51"
;;

+>------cp "$tmp" $TMPMOUNT/uInitrd
+>------rm -f "$tmp"

Maybe you could just mv?  Doesn't matter much though.

+>------rm -rf $TMPMOUNT
This should be rmdir; ifyou can do with just a rmdir, you're risking less data 
than if you use rm -rf.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/723082

Title:
  flash-kernel doesn't handle uboot in mx51evk

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to