On Tue, 2011-03-15 at 08:29 +0000, Martin Pitt wrote: > Just cross-checking: > > $ scour --disable-style-to-xml -i gnome-dev-pcmcia.svg -o o.svg > $ ~/debian/scour/debian/cmpsvg gnome-dev-pcmcia.svg o.svg > difference: 3.352% > > So these cases should be caught even with the current dh_scour treshold. >
Yup, the 18 icons i noticed now with rev 207 from lp:scour , did *not* get through earlier. But what I am concerned in this bug was that the 0.5% check was not good and let a different set of icons got altered *visibly* when scour was not working properly. Right now, rev 207 is good, with most icons, but I was concerned is that this could happen again in a later rev and similarly we would have the same problem of some random icons getting corrupted. Hence I'm OK if a 0.0% check is set for Humanity, this would ensure nothing corrupted gets through. > Also, I noticed that the diff calculcation in the current natty scour > package is wrong, I fixed that. > Lets hope this was the only cause they got through.. :-) If we want to check exactly what percent got though with the old diff calculation, we could check : /usr/share/icons/Humanity/categories/48/applications-sports.svg /usr/share/icons/Humanity/categories/48/applications-geography.svg /usr/share/icons/Humanity/apps/48/evolution.svg /usr/share/icons/Humanity/apps/48/wmtweaks.svg /usr/share/icons/Humanity/apps/32/wmtweaks.svg /usr/share/icons/Humanity/actions/48/window-new.svg /usr/share/icons/Humanity/apps/32/gnome-panel-force-quit.svg /usr/share/icons/Humanity/categories/48/applications-utilities.svg /usr/share/icons/Humanity/devices/48/media-cdr.svg /usr/share/icons/Humanity/devices/48/media-cdrom-audio.svg /usr/share/icons/Humanity/devices/48/media-cdrw.svg /usr/share/icons/Humanity/devices/48/media-dvd.svg Any idea what the diff for these were? -- Cheers, Vish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/734955 Title: Remove scour dependancy while building Humanity -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
