I just went through all the other lsb functions in lsb-base-logging.sh, here's 
a quick report:
log_action_begin_msg            CALLS log_daemon_msg
log_action_cont_msg             CALLS log_daemon_msg 
log_action_end_msg              CALLS log_end_msg
log_action_msg                  DIRECT echo
log_begin_msg                   CALLS log_daemon_msg
log_daemon_msg                  UPDATED
log_end_msg                     UPDATED
log_failure_msg                 DIRECT echo
log_progress_msg                DOES NOTHING
log_success_msg                 DIRECT echo
log_warning_msg                 DIRECT echo

"DIRECT echo"  means a direct call to "echo" without the "-n" parameter, so 
shouldn't break boot.log
"DOES NOTHING" means the function is just executing "true" (":")
"UPDATED" is the two functions I had to update to detect plymouth and store the 
text in a variable until log_end_msg is called.
The rest is just calling the functions I patched.

Output seems relatively good now, it's definitely not worse than it was without 
the patch.
As mentioned before the only remaining "issues" is init scripts directly 
calling echo (can't really do anything about that) and scripts like apparmor 
doing:
 1) log_daemon_msg
 2) log_action_msg
 3) log_end_msg

Where the old behaviour would have been:
 1) Show something like " * Starting AppArmor profiles"
 2) Add: "Skipping profile in /etc/apparmor.d/disable: usr.bin.firefox"
 3) Finishes the line (actually the next line due to 80 chars limit): "[ OK ]"

And the new one is:
 1) Put " * Starting AppArmor profiles" in a variable, doesn't print anything
 2) Shows" Skipping profile in /etc/apparmor.d/disable: usr.bin.firefox"
 3) Shows " * Starting AppArmor profiles  [ OK ]"

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/752393

Title:
  lsb init scripts show line buffering problems on bootup

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to