The reason of the bug is that : 
1. In softwareproperties/SoftwareProperties.py, a thread is created

  def check_and_add_key_for_whitelisted_channels(self, srcline):
[...]
    if parsed_uri.netloc == 'ppa.launchpad.net':
      worker = AddPPASigningKeyThread(parsed_uri.path)
      worker.start()

2. When failing in method add_ppa_signing_key of AddPPASigningKeyThread class, 
it prints an error and return False : 
[...]
        except URLError, e:
            print "Error reading %s: %s" % (lp_url, e)
            return False

3. But the return code generated by the thread is nowhere managed. In fact, two 
lines are inconditionnaly added in source file : 
  def add_source_from_line(self, line):
[...]
    self.check_and_add_key_for_whitelisted_channels(deb_line)
    self.sourceslist.list.append(new_deb_entry)
    self.sourceslist.list.append(new_debsrc_entry)

Hope it helps...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/496879

Title:
  add-apt-repository should return exit code and not adding wrong
  repositories

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/496879/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to