Public bug reported:

This expression in Launcher.cpp: Launcher::OnUpdateDragManagerTimeout appears 
to be partially useless:
  mask | (Button1Mask & Button2Mask & Button3Mask)

Because "Button1Mask & Button2Mask & Button3Mask" are mutually
exclusive, the value will always be zero.

It looks like maybe the author meant:
  mask & (Button1Mask | Button2Mask | Button3Mask)

** Affects: unity
     Importance: Undecided
         Status: New

** Affects: unity (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: unity
   Importance: Undecided
       Status: New

** Summary changed:

- unity: Dead code in Launcher.cpp: "mask | (Button1Mask & Button2Mask & 
Button3Mask))"
+ unity: Dead code in Launcher.cpp: "mask | (Button1Mask & Button2Mask & 
Button3Mask)"

** Description changed:

  This expression in Launcher.cpp: Launcher::OnUpdateDragManagerTimeout appears 
to be partially useless:
-   mask | (Button1Mask & Button2Mask & Button3Mask))
+   mask | (Button1Mask & Button2Mask & Button3Mask)
  
  Because "Button1Mask & Button2Mask & Button3Mask" are mutually
  exclusive, the value will always be zero.
  
  It looks like maybe the author meant:
-   mask & (Button1Mask | Button2Mask | Button3Mask))
+   mask & (Button1Mask | Button2Mask | Button3Mask)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/805327

Title:
  unity: Dead code in Launcher.cpp: "mask | (Button1Mask & Button2Mask &
  Button3Mask)"

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/805327/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to