While I appreciate your enthusiasm and desire to fix this I have a few comments:
1) Unless I missed something your implementation always reads the whole database file, I would rather avoid that. 2) The similar result search you employed is much weaker than the one used by current implementation, you do not look for any permutations of the input string, just for substrings. 3) Plan on how to migrate those features (or not) to your new implementation 4) Do not use hacks like the one with parsing apt files, in general they tend to strike back sooner than we expect. 4) Propose a merge request, start with a alternative implementation skeleton, then add new pieces one by one, I'll gladly review them. 5) Initially ensure that the output is the same, this will simplify testing. We can change the output of both implementations later if we so desire. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/598282 Title: command-not-found slow for its task To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/command-not-found/+bug/598282/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
