Thanks for your hard work on keeping mame up to date! This looks mostly
good, but I have a few issues:
A few questions:
- In the 0.141 package, mame-tools depended on mame-common. Since you
merged that into mame, should mame-tools not depend on mame (=
${source:Version}) now?
- I see several suggestions for the xmame packages. Will any of them be
affected by the merge of mame-common into mame?
- This is much less important, but have you looked into using
dh_usrlocal instead of creating the directories in maintainer scripts
yourself? I think you should be able to list the directories in
debian/*.dirs and then let dh_usrlocal cleanup.
A few things that definitely should be fixed:
- So long as the package is still in Ubuntu and not getting synced from
Debian, the maintainer should remain an @ubuntu.com e-mail address
- The Debian Policy manual generally recommends against using Conflicts
with a "earlier than" version clause (http://www.debian.org/doc/debian-
policy/ch-relationships.html#s-conflicts); you should use Breaks
instead. Also, since mame now contains files that were previously in
mame-common, mame should also Replaces: mame-common (<< 0.143)
And finally a few notes that will make your changes easier for sponsors
to review in the future:
- It took me a few minutes to realize you had written a get-orig-source
target in debian/rules. Since the orig source requires mangling and you
didn't attach it directly, it speeds alone the sponsorship process if
you mention that directly
- For version upgrade sponsorship, the thing I'm most interested in
seeing as a sponsor is the debdiff between the two releases, preferably
just confined to the debian/ directory. Something like `debdiff
{a,b}.dsc | filterdiff -i '*/debian/*'` should capture that. Generating
and attaching that also makes the package easier to review
I'm going to go ahead and unsubscribe ubuntu-sponsors for the moment.
Once you've addressed the issues above, feel free to resubscribe
sponsors for another review.
** Changed in: mame (Ubuntu)
Status: In Progress => Confirmed
** Changed in: mame (Ubuntu)
Assignee: Evan Broder (broder) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/803468
Title:
[Need Packaging] New upstream release 0.143
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mame/+bug/803468/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
