Comment on attachment 550239
Add pulseaudio support for GTK nsISound.play impl
Review of attachment 550239:
-----------------------------------------------------------------
::: widget/src/gtk2/nsSound.cpp
@@ +129,5 @@
> +typedef struct pa_sample_spec {
> + pa_sample_format_t format;
> + uint32_t rate;
> + uint8_t channels;
> +} pa_sample_spec;
This is okay for now, but I'd prefer to include the headers. Please
file a follow up bug to deal with this when bug 662417 is fixed.
@@ +417,5 @@
> + pa_simple* s = pa_simple_new(NULL, name.get(), PA_STREAM_PLAYBACK,
> NULL, "mozillaSound", &ss, NULL, NULL, NULL);
> + if (!s)
> + return NS_ERROR_OUT_OF_MEMORY;
> +
> + pa_simple_write(s, audio, audio_len, NULL);
You need to call pa_simple_drain here, otherwise playback may end
prematurely when |s| is freed.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/732572
Title:
New Mail Notification Sound does not play in Natty
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/732572/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
