Hi Daniel Thanks for taking the time to prepare a revised debdiff for this upgrade.
Looking at the debdiff and reviewing Jamie previous comments I have the following feedback: 1) debian/munin-node.postinst is modified in the debdiff but not mentioned in the merge changelog entry; I assume that this is something todo with the upstart conversion but this should be documented for future merges. 2) debian/changelog - some of the changelog comments for Fixes have got muddled with the Merge comment - makes it a little difficult to read; please could you also annotate the entry for upstream_bug_832.patch including the LP bug report? Great job on tagging the patches - I reviewed and they all appear to make sense to me. Ditto Jamie's comment re submission back to Debian if they have not been submitted already. Cheers James -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/840386 Title: Update munin to bugfix release 1.4.6 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/munin/+bug/840386/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
