Thanks for the patch. I had to merge this up with the current version in precise anyway, and along the way, there are a few things I think could be improved:
* The $(origin CC) stuff is overcomplicated. We don't need to patch the upstream Makefile to support overriding debian/rules, as the ordinary semantics of make already allow us to do so; all we need to do is pass CC=$(DEB_HOST_GNU_TYPE)-gcc on make's command line, rather than as an environment variable. (I'd rather we established patterns that involved minimal need to patch upstream files wherever possible; 'CC = gcc' is extremely common and it would be good not to have to patch that all over the place.) * Using -lfoo as a prerequisite indeed won't work with cross-building, so I agree that we need to patch the upstream Makefile for that. I'm not comfortable with doing so by adding unnecessary linkage to all output executables, though. A neater way is to use target-specific variables, e.g. 'arping: LDLIBS = -lsysfs'. * We should have a DEP-3 patch header for the remaining upstream patch. I've gone ahead and done this, tested it in my cross-building environment, and uploaded to precise; patch attached. I'll forward this to Debian shortly. Let me know if you think something still needs to be revised, of course! ** Patch added: "iputils_20101006-1ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/iputils/+bug/872370/+attachment/2589352/+files/iputils_20101006-1ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/872370 Title: iputils fails to cross-build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iputils/+bug/872370/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
