We should also check against the ACPI FADT table that contains the model
type (e.g. mobile, desktop etc) and correlate this with the DMI data.

Section 5.2.9 of the ACPI spec, Preferred_PM_Profile may help us infer that the 
system should have a battery or not.
Section 7.4.1 of the SMBIOS spec "System Enclosure or Chassis Types", table 16 
also can help us infer if the system should have a battery.

In both cases above, we may have to contend with either "unknown" or
badly defined fields and maybe settings in the FADT and DMI data that
could be incorrectly set and/or contradictory.

Also, /proc/acpi/battery is the old (to be deprecated interface), so
best to call the fwts helper: fwts_battery_get_capacity() to see if we
can get battery info via the /proc or /sys interfaces.

A couple of points:
1.  If a machine is mobile then I think we can safely assume it should have a 
battery.
2.  However, if a machine has a battery, can we assume it is a mobile device?  
I'm not 100% sure.

@Alexhung,  any ideas on points 1 + 2?

@cr3, do we want this as part of a new fwts test or sub-part of a set of
already existing tests, e.g. in the DMI check for the DMI case and an
acpitables check for the ACPI check?  Or no preference as long as it's
checked?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/897298

Title:
  fwts should test chassis type

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/897298/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to