Hi Louis,

+
+log_begin_msg "Saving vmcore from kernel crash"
+
+mount $rootmnt -o remount,rw
+
 # Make sure makedumpfile assumptions are satisfied.
-while ! test -e "$INFO"; do
+while ! test -e "$rootmnt/$INFO"; do
        panic "kdump: Missing $INFO"
 done
-while ! test -x "$MAKEDUMPFILE"; do
-       panic "kdump: Missing $MAKEDUMPFILE"
+
+while ! test -x "$rootmnt/$MAKEDUMPFILE"; do
+       panic "kdump: Missing $rootmnt/$MAKEDUMPFILE"
 done
 
-log_begin_msg "Saving vmcore from kernel crash"
-
-mount $rootmnt -o remount,rw

This doesn't look like a good change to me.  remounting the rootfs read-
write before calling panic just increases the chance that we'll have to
fsck on the next reboot due to an unclean unmount.  Was there a
particular reason for this earlier mounting?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/785425

Title:
  0_kdump uses dynamic makedumpfile(8) binary, which fails horribly

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kexec-tools/+bug/785425/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to