Launchpad has imported 12 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=691898.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2011-10-04T20:39:11+00:00 Landry-openbsd wrote: Since landing of bug #684039, js/src/yarr/pcre fails to build on sparc64 (non-methodjit, non-tracejit) with the following errors : js/src/yarr/pcre/pcre_exec.cpp:49:21: error: jsarena.h: No such file or directory js/src/yarr/pcre/pcre_exec.cpp:96: error: ISO C++ forbids declaration of 'JSArenaPool' with no type js/src/yarr/pcre/pcre_exec.cpp:96: error: expected ';' before '*' token js/src/yarr/pcre/pcre_exec.cpp:99: error: 'JSArenaPool' has not been declared full trace in http://buildbot.rhaalovely.net/builders/comm-central- sparc64/builds/158/steps/build/logs/stdio .. i'm surprised this hasnt been catched by try/tbpl. I don't know that code but it seems pcre_exec.cpp needs a bit of rewrite since that commit. I'm open to any suggestions, or cluebats explaining what i've done wrong. Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/0 ------------------------------------------------------------------------ On 2011-10-04T21:53:12+00:00 Christopher-leary wrote: PCRE isn't used in any of the supported builds (we only compile for "tier 1" platforms). We actually removed it a while back, but it seems to have been re-added in bug 684559. Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/1 ------------------------------------------------------------------------ On 2011-10-11T00:53:24+00:00 Dmandelin wrote: Chris, can you provide any hints for how to replace the JSArenaPool usage? Did it just move to a different file? Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/2 ------------------------------------------------------------------------ On 2011-10-11T16:58:44+00:00 Christopher-leary wrote: (In reply to David Mandelin from comment #2) > Did it just move to a different file? No, it was rewritten as js::LifoAlloc. The interface changes are straightforward, JS_ARENA_MARK => js::LifoAlloc::mark. For the JS_ARENA_ALLOCATE_CAST there's are ::new_ and ::alloc_ functions on the LifoAlloc. Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/3 ------------------------------------------------------------------------ On 2011-10-14T14:43:19+00:00 Spectre wrote: I think I can generate a patch (unless Landry does it first). Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/4 ------------------------------------------------------------------------ On 2011-10-14T14:49:50+00:00 Spectre wrote: I probably should try to fix bustage from bug 673188 at the same time. The options are temporarily commit a change to js/src/Makefile.in to allow builds to continue using the slower YARR interpreter, in the hopes that lazy regexps will mitigate the hit going from PCRE. The other option is to try to deal with both at the same time. The final option is to do both: commit the bandaid, then try to commit a better fix. Which would be okay with you, Chris/David? Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/5 ------------------------------------------------------------------------ On 2011-11-11T13:16:56+00:00 Jndiogo wrote: At jsRegExpExecute(), PCRE is trying to use the JSContext->regExpPool (which no longer exists) in the call to match(). Do you see any problem in using JSContext::tempLifoAlloc() and using that LifoAlloc instead? Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/6 ------------------------------------------------------------------------ On 2011-11-11T16:57:28+00:00 Spectre wrote: No, that's the easy part. The hard part is bug 673188 because PCRE doesn't really have a syntax checking step. I need a Mozilla call: fix, or issue an intermediate patch to build with YARR interpreter until a final fix? Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/7 ------------------------------------------------------------------------ On 2011-12-24T08:50:50+00:00 Mh+mozilla wrote: I would say build with the YARR interpreter. There are chances PCRE breaks again in the future as the JS engine evolves. (And as a matter of fact, in beta, it fails on jstl.h missing before failing on jarena.h...) Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/8 ------------------------------------------------------------------------ On 2011-12-24T08:58:12+00:00 Mh+mozilla wrote: Created attachment 584166 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/9 ------------------------------------------------------------------------ On 2011-12-24T17:50:55+00:00 Spectre wrote: I'm good with that. We're using YARR JIT in PowerPC now anyway. Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/10 ------------------------------------------------------------------------ On 2011-12-26T07:34:38+00:00 Mh+mozilla wrote: Comment on attachment 584166 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported This patch is incomplete. Reply at: https://bugs.launchpad.net/firefox/+bug/908508/comments/12 ** Changed in: firefox Status: Unknown => In Progress ** Changed in: firefox Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
