thanks for your contribution to ubuntu.

I modified the debdiff a bit adding this:
  * wrap-and-sort debian/
  * convert copyright to dep5 format
  * use dh_python2 instead of pysupport

please review the changes I made and check if the package still works
correctly. the largest change is the use of dh_python2 instead of the
deprecated pysupport.

I don't like the uses of os.system in the source e.g.
os.system(wakeup_script + " $USER " + re.search("\d+",folder).group(0) + " test 
&")
and many more.
I'm not sure if those can be used to for priviledge escalations but I still 
prefer those unsafe system calls to be fixed by using the subprocess module 
(without shell=True) before I upload this.

** Attachment added: "wakeup_1.2-0ubuntu1.debdiff.gz"
   
https://bugs.launchpad.net/ubuntu/+source/wakeup/+bug/909189/+attachment/2650568/+files/wakeup_1.2-0ubuntu1.debdiff.gz

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/909189

Title:
  Request for new upstream version 1.2 upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wakeup/+bug/909189/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to