Looks fine to me. Builds ok with just main, looks maintainable, no
security issues, packaging looks good. Would be good to have a man page
for /usr/bin/ncftool, but that won't hold up this MIR. Since these
commands will be running as root, I spotted checked the code, and memory
allocations, etc seem to be handled well.
There is a test suite available and I would like to see it enabled in
the build as a condition of this MIR. 'make check' seems to work just
fine without requiring network access. Marking 'In Progress'.
** Changed in: netcf (Ubuntu)
Status: Confirmed => In Progress
** Changed in: netcf (Ubuntu)
Assignee: Jamie Strandboge (jdstrand) => (unassigned)
** Changed in: netcf (Ubuntu)
Assignee: (unassigned) => Serge Hallyn (serge-hallyn)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/904014
Title:
[MIR] netcf
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/netcf/+bug/904014/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
