Though, with respect to comment #2, we could just fix the broken undo
code causing this bug without reverting the fix for bug 865179.

** Description changed:

  When you resize a (new) terminal window, it only resizes in increments
  of the character size. This is correct behaviour. However after the Grid
  plugin has touched a window, it loses its resize increments/granularity.
  
  Video attached.
  
+ TESTCASE:
+ 1. Open a Terminal.
+ 2. Resize it. Verify that it only resizes in granular increments.
+ 3. Drag the window to the left or right of the screen to trigger Grid.
+ 4. Restore the window.
+ 5. Resize it again. Notice the granular increments are gone. That is the bug.
+ Expected result:
+ 5. Resize it again. Verify that it only resizes in granular increments.
+ 
+ 
  I suspect this is the cause (in grid.cpp):
-                 /* Be evil */
-                 if (cw->sizeHints ().flags & PResizeInc)
-                 {
-                     gw->sizeHintsFlags |= PResizeInc;
-                     gw->window->sizeHints ().flags &= ~(PResizeInc);
-                 }
+                 /* Be evil */
+                 if (cw->sizeHints ().flags & PResizeInc)
+                 {
+                     gw->sizeHintsFlags |= PResizeInc;
+                     gw->window->sizeHints ().flags &= ~(PResizeInc);
+                 }
  and it seems the restore code to undo the above hack never gets called:
-     if (gw->isGridMaximized & !(cw->state () & MAXIMIZE_STATE))
-     {
-         gw->window->sizeHints ().flags |= gw->sizeHintsFlags;
-         gw->isGridMaximized = false;
+     if (gw->isGridMaximized & !(cw->state () & MAXIMIZE_STATE))
+     {
+         gw->window->sizeHints ().flags |= gw->sizeHintsFlags;
+         gw->isGridMaximized = false;

** Tags added: testcase

** Summary changed:

- [regression] Window resize granularity is lost after being semi-maximized by 
the Grid plugin
+ [regression] Window resize granularity is lost when restored after using Grid

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/925867

Title:
  [regression] Window resize granularity is lost when restored after
  using Grid

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz-grid-plugin/+bug/925867/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to