I have moved the package to the Resara Server code repository. To build the source package,
hg clone https://bitbucket.org/resara/resara-server cd resara-server/rds/packages/precise/ ./debian/rules get-orig-source dpkg-buildpackage -S I've resolved most of the issues you've raised. See my comments below. On Mon, Feb 13, 2012 at 6:22 AM, James Page <[email protected]> wrote: > Hi Brendan > > First of all thanks for taking the time to package rds for Ubuntu - > looks like a really interesting project! > > I have had a review of the packaging that you have provided in PPA - > here is the feedback: > > 1) Lintian warnings/errors on resulting binary packaging > > Although the source packaging is lintian clean, the resulting binary > package still show quite a few warnings/errors; I've broken them down by > type to make it a bit more digestable. > > 2) debian/copyright and licensing > > Please could you update for DEP-5 machine readable format - see > http://dep.debian.net/deps/dep5/ > > E: libqtrpc2: copyright-should-refer-to-common-license-file-for-lgpl > W: libqtrpc2: copyright-without-copyright-notice > E: librdsclient-dev: copyright-should-refer-to-common-license-file-for-lgpl > W: librdsclient-dev: copyright-without-copyright-notice > E: libqtrpc2-dev: copyright-should-refer-to-common-license-file-for-lgpl > W: libqtrpc2-dev: copyright-without-copyright-notice > E: librdsldap-dev: copyright-should-refer-to-common-license-file-for-lgpl > W: librdsldap-dev: copyright-without-copyright-notice > E: librdsserver-dev: copyright-should-refer-to-common-license-file-for-lgpl > W: librdsserver-dev: copyright-without-copyright-notice > W: librdsserver-dev: readme-debian-contains-debmake-template > E: rdsconsole: copyright-should-refer-to-common-license-file-for-lgpl > W: rdsconsole: copyright-without-copyright-notice > E: librdsldap: copyright-should-refer-to-common-license-file-for-lgpl > W: librdsldap: copyright-without-copyright-notice > E: rds: copyright-should-refer-to-common-license-file-for-lgpl > W: rds: copyright-without-copyright-notice > E: librdsserver: copyright-should-refer-to-common-license-file-for-lgpl > W: librdsserver: copyright-without-copyright-notice > E: rdsserver: copyright-should-refer-to-common-license-file-for-lgpl > W: rdsserver: copyright-without-copyright-notice > E: librdsclient: copyright-should-refer-to-common-license-file-for-lgpl > W: librdsclient: copyright-without-copyright-notice > E: rdsutils: copyright-should-refer-to-common-license-file-for-lgpl > W: rdsutils: copyright-without-copyright-notice > I have updated the copyright file to the format you suggested, and added a reference to Debian's license files rds/windeps/BonjourPSSetup.exe: does this have the same licensing as the > main source package? > This file has been removed. > > 3) debian/control: > > All of the package description/extended descriptions are the same - it > would be great to get more information about the individual packages. > Generic information in each is fine so long as its supplemented by > information specific to the binary package. > > W: rdsconsole: description-synopsis-starts-with-article > W: rdsconsole: extended-description-line-too-long > W: librdsldap: description-synopsis-starts-with-article > W: librdsldap: extended-description-line-too-long > W: rds: description-synopsis-starts-with-article > W: rds: extended-description-line-too-long > W: librdsserver: description-synopsis-starts-with-article > W: librdsserver: extended-description-line-too-long > W: librdsserver: description-synopsis-starts-with-article > W: librdsserver: extended-description-line-too-long > W: librdsserver: description-synopsis-starts-with-article > W: librdsserver: extended-description-line-too-long > W: rdsserver: description-synopsis-starts-with-article > W: rdsserver: extended-description-line-too-long > W: librdsclient: description-synopsis-starts-with-article > W: librdsclient: extended-description-line-too-long > W: rdsutils: description-synopsis-starts-with-article > W: rdsutils: extended-description-line-too-long > W: librdsserver-dev: description-synopsis-starts-with-article > W: librdsserver-dev: extended-description-line-too-long > W: librdsldap-dev: description-synopsis-starts-with-article > W: librdsldap-dev: extended-description-line-too-long > W: librdsclient-dev: description-synopsis-starts-with-article > W: librdsclient-dev: extended-description-line-too-long > E: libqtrpc2-dev: description-synopsis-is-duplicated > W: libqtrpc2-dev: spelling-error-in-description developement development > E: libqtrpc2: description-synopsis-is-duplicated > I have updated the package descriptions. Each package now has a more informative description. > > 4) libXXX-dev packages > > I can see headers on the libXXX-dev packages; I would normally also > expect and un-versioned .so .a files to support development usage but > they are not present in either the -dev packages or the standard libXXX > package as far as I can see. > All of the .so files are now packaged in the right places. > 5) qtrpc2 > > I noticed that you have bundled what I think is > http://code.google.com/p/qtrpc2/ in the rds source tree - is this the > case? It would be much more preferable to have this as a separate > library. > This is just an old snapshot of qtrpc2, main development now goes on in the Resara Server mercurial repository. > > libqtrpc2 contains and unversioned .so file which should really be in > the -dev package: > This has been fixed > > W: libqtrpc2: non-dev-pkg-with-shlib-symlink usr/lib/libqtrpc2.so.1.0.0 > usr/lib/libqtrpc2.so > > It also looks like this part of the source tree is licensed under the > BSD three clause license rather than GPL/LGPL. > The QtRPC2 library is BSD licensed. It is marked as such in the control file, and in the copyright file. > > 6) libXXX naming > > Libraries should really be versioned in the binary package names; this > helps when you want to transition to a new ABI as it makes it clear when > the transition is complete and when ABI compatibility changes: > > W: librdsclient: package-name-doesnt-match-sonames librdsclient1.0 > W: librdsldap: package-name-doesnt-match-sonames librdsldap1.0 > W: librdsserver: package-name-doesnt-match-sonames librdsserver1.0 > W: libqtrpc2: package-name-doesnt-match-sonames libqtrpc2-1.0 > > http://www.debian.org/doc/debian-policy/ch-sharedlibs.html provide > guidance on packaging shared libaries. > The library packages now end in their SONAMES. librdsserver has become librdsserver1, etc.. > > 7) Platform independent files > > Platform independent files should be installed in /usr/share rather than > /usr/lib: > > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/blockdevice.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/cancel.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/cdrom.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/clear_left.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/clock.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/eject.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/folder.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/folder_green.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/folder_html.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/folder_orange.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/folder_red.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/hdd.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/hdd_unmount.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/logs.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/network.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/network_local.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/password.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/pencil.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/plug.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/server.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/status.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/system.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/16x16/template_source.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/unplug.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/usbdisk.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/16x16/userconfig.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/add.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/daemons.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/32x32/disksfilesystems.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/down.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/exec.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/32x32/folder_html.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/kcontrol.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/32x32/mail_generic.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/network.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/32x32/network_local.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/package.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/reload.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/remove.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/system.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/unlock.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/up.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/32x32/userconfig.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/48x48/input_devices_settings.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/48x48/kcontrol.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/48x48/kuser.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/48x48/server.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/64x64/folder_html.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/64x64/network_local.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/64x64/package.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/64x64/system.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/banner.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/hi32-group.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/install-banner.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/install-box.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/install-gradient.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-0.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-1.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-10.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-11.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-2.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-3.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-4.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-5.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-6.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-7.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-8.png > W: rdsconsole: image-file-in-usr-lib > usr/lib/rds/icons/loading/loading-9.png > W: rdsconsole: image-file-in-usr-lib usr/lib/rds/icons/rdsconsole.png > > If rds relies on these being in /usr/lib then I would suggest installing > them in /usr/share/rds and providing a symlink from /usr/lib/rds/icons. > The icons are now installed in /usr/share/rds/icons, with a symlink in /usr/lib/rds/icons > > 8) Missing manpages > > Fairly self explanatory; note that this won't block acceptance into the > archive but does make things easier for end users! > > W: rdsconsole: binary-without-manpage usr/bin/rdsconsole > W: rdsserver: binary-without-manpage usr/sbin/rdsd > W: rdsutils: binary-without-manpage usr/bin/rdsacledit > W: rdsutils: binary-without-manpage usr/bin/rdscontrol > W: rdsutils: binary-without-manpage usr/bin/rdsprovision > I have not added manpages. I had planed to write them for the next release. I may have time to write them before then, and if so I will update the package. > > 9) Missing LSB Section > > The init script for rdsserver is missing some information; again not a > blocker. It would be great to see an upstart configuration at some > point in the future! > > W: rdsserver: init.d-script-missing-lsb-section etc/init.d/rdsserver > I have added the LSB section to the init script > > 10) Empty binary package > > rds should really be labled as a meta-package and targetted at > architecture: all > > W: rds: empty-binary-package > > See http://lintian.debian.org/tags/empty-binary-package.html I have marked rds as a meta-package in the control file. > > > Ping me in #ubuntu-server if you have any queries. > > Cheers > > James > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/930422 > > Title: > [needs-packaging] rds Resara Server > > Status in Ubuntu: > New > > Bug description: > Resara Server is an Active Directory compatible open source server for > small businesses designed around Samba 4. It is designed to be simple > and easy to use. The management console lets you manage users, share > files, and configure DHCP and DNS. > > Home Page: http://www.resara.org/ > License: GPL2/LGPL2/BSD > Launchpad PPA: > https://launchpad.net/~resaraserver/+archive/resaraserver-testing > > I've built a package for Ubuntu 12.04(Precise). It passes lintian > without errors or warnings, and builds in pbuilder and launchpad. > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+bug/930422/+subscriptions > -- ----------------------- Brendan Powers Resara LLC 1.888.357.9195 www.resara.com -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/930422 Title: [needs-packaging] rds Resara Server To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/930422/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
