(In reply to David Mandelin from comment #91) > (In reply to Mike Hommey [:glandium] from comment #90) > > Yes. That these things are in Makefile.in is a mistake anyways. > > JSC sets those flags in what we imported as assembler/wtf/Platform.h, which > seems reasonable. In fact, I see they set ENABLE_ASSEMBLER in there > depending on various conditions, which is maybe why the patch works on most > platforms already.
Erm... looking at Platform.h, ENABLE_ASSEMBLER is set : - #if WTF_PLATFORM_WX -> wxWidgets ? Seriously ? - #if WTF_CPU_SH4 && WTF_PLATFORM_QT -> does it concern mozilla ? - #if ENABLE_JIT || ENABLE_YARR_JIT -> so enabling yarr jit sets ENABLE_ASSEMBLER. Given that, why bothering setting ENABLE_ASSEMBLER at all in Makefile.in ? Are there cases where METHODJIT is enabled and YARR JIT is not ? What a #define maze.. > js-config.h also seems like a reasonable place, although since there is > already ENABLE_ASSEMBLER and ENABLE_JIT stuff in Platform.h, maybe it will > be easier to keep consistent if we do it there. Wait, so what should move where ? ENABLE_YARR_JIT & ENABLE_ASSEMBLER to js-config.h & configure.in ? ENABLE_YARR_JIT to Platform.h ? Do we keep the list of yarr jit architectures in Makefile.in ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
