Ok, so I have verified verbally with David (and per his comment #8
above) that we are to go with requiring sign-in along with
recommendations opt-in. In fixing bug 973612, I have implemented most of
what we need for this bug as well.

  lp:~gary-lasker/software-center/recommendations-sso-login-lp973612

The above branch implements the SSO sign-in specifically for
recommendations, and it reuses the already-existing opt-in text from the
lobby panel in the SSO dialog itself so that we can avoid adding a whole
new string so far after string freeze. This seems a perfectly reasonable
approach to me, and I have added a FIXME in the code to change this text
at a later date if we deem it necessary.

The above branch also handles the case where the user has previously
opted-in but later the Ubuntu SSO token is found to have been removed,
revoked, or otherwise invalid (in other words, it is always checked
now). In this case, the SSO dialog is displayed again and if it it
cancelled, the user is opted-out of recommendations and the previous
opt-in panel is restored (see bug 973612).

The user can choose to opt-in again at any time.

The only piece remaining to do for *this* bug, then, is to remove the
word "anonymous" from the opt-in text. I'll make a second branch (that
depends on the branch above) to do that.

Thanks, all!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/967064

Title:
  Opting in to recommendations asks you to sign in

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/967064/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to