** Description changed:

+ [Impact] cloning of repositories with bad data from rebases fails
+ 
+ [Development Fix] fix backported from upstream vcs to handle the issue
+ 
+ [Stable Fix] same fix applies to stable
+ 
+ [Test Case]
+ put this in ~/.hgrc :
+ [extensions]
+ hgext.bookmarks =
+ hgext.git =
+ 
  hg clone git://git.debian.org/git/pkg-kde/kde-std/calligra.git
  
+ expected: a clone
+ result: ValueError: need more than 1 value to unpack
  
- destination directory: calligra                                               
                                                                                
                                             
- importing Hg objects into Git                                                 
                                                                                
                                             
- ["git-upload-pack '/git/pkg-kde/kde-std/calligra.git'"]                       
                                                                                
                                             
- Counting objects: 349, done.                                                  
                                                                                
                                             
- Compressing objects: 100% (270/270), done.                                    
                                                                                
                                             
- Total 349 (delta 126), reused 134 (delta 0)                                   
                                                                                
                                             
- importing Git objects into Hg                                                 
                                                                                
                                             
- ** unknown exception encountered, please report by visiting                   
                                                                                
                                             
+ [Regression Potential] low, only handles a situation which prevously
+ caused a crash every time
+ 
+ 
+ hg clone git://git.debian.org/git/pkg-kde/kde-std/calligra.git
+ 
+ destination directory: calligra
+ importing Hg objects into Git
+ ["git-upload-pack '/git/pkg-kde/kde-std/calligra.git'"]
+ Counting objects: 349, done.
+ Compressing objects: 100% (270/270), done.
+ Total 349 (delta 126), reused 134 (delta 0)
+ importing Git objects into Hg
+ ** unknown exception encountered, please report by visiting
  **  http://mercurial.selenic.com/wiki/BugTracker
  ** Python 2.6.7 (r267:88850, Jul 10 2011, 08:11:54) [GCC 4.6.1]
  ** Mercurial version 1.8.3, système de gestion de sources distribué
  ** Extensions chargées : git, transplant
  Traceback (most recent call last):
-   File "/usr/bin/hg", line 38, in <module>
-     mercurial.dispatch.run()
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 16, in run
-     sys.exit(dispatch(sys.argv[1:]))
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 36, in 
dispatch
-     return _runcatch(u, args)
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 58, in 
_runcatch
-     return _dispatch(ui, args)
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 601, in 
_dispatch
-     cmdpats, cmdoptions)
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 406, in 
runcommand
-     ret = _runcommand(ui, options, cmd, d)
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 655, in 
_runcommand
-     return checkargs()
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 609, in 
checkargs
-     return cmdfunc()
-   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 598, in 
<lambda>
-     d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
-   File "/usr/lib/pymodules/python2.6/mercurial/util.py", line 433, in check
-     return func(*args, **kwargs)
-   File "/usr/lib/pymodules/python2.6/mercurial/commands.py", line 825, in 
clone
-     branch=opts.get('branch'))
-   File "/usr/lib/pymodules/python2.6/mercurial/hg.py", line 335, in clone
-     dest_repo.clone(src_repo, heads=revs, stream=stream)
-   File "/usr/lib/pymodules/python2.6/mercurial/localrepo.py", line 2014, in 
clone
-     return self.pull(remote, heads)
-   File "/usr/lib/pymodules/python2.6/hgext/git/hgrepo.py", line 14, in pull
-     git.fetch(remote.path, heads)
-   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 104, in 
fetch
-     self.import_git_objects(remote_name, refs)
-   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 415, in 
import_git_objects
-     self.import_git_commit(commit)
-   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 422, in 
import_git_commit
-     hg_branch, extra) = self.extract_hg_metadata(commit.message)
-   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 812, in 
extract_hg_metadata
-     command, data = line.split(" : ", 1)
+   File "/usr/bin/hg", line 38, in <module>
+     mercurial.dispatch.run()
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 16, in run
+     sys.exit(dispatch(sys.argv[1:]))
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 36, in 
dispatch
+     return _runcatch(u, args)
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 58, in 
_runcatch
+     return _dispatch(ui, args)
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 601, in 
_dispatch
+     cmdpats, cmdoptions)
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 406, in 
runcommand
+     ret = _runcommand(ui, options, cmd, d)
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 655, in 
_runcommand
+     return checkargs()
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 609, in 
checkargs
+     return cmdfunc()
+   File "/usr/lib/pymodules/python2.6/mercurial/dispatch.py", line 598, in 
<lambda>
+     d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
+   File "/usr/lib/pymodules/python2.6/mercurial/util.py", line 433, in check
+     return func(*args, **kwargs)
+   File "/usr/lib/pymodules/python2.6/mercurial/commands.py", line 825, in 
clone
+     branch=opts.get('branch'))
+   File "/usr/lib/pymodules/python2.6/mercurial/hg.py", line 335, in clone
+     dest_repo.clone(src_repo, heads=revs, stream=stream)
+   File "/usr/lib/pymodules/python2.6/mercurial/localrepo.py", line 2014, in 
clone
+     return self.pull(remote, heads)
+   File "/usr/lib/pymodules/python2.6/hgext/git/hgrepo.py", line 14, in pull
+     git.fetch(remote.path, heads)
+   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 104, in 
fetch
+     self.import_git_objects(remote_name, refs)
+   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 415, in 
import_git_objects
+     self.import_git_commit(commit)
+   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 422, in 
import_git_commit
+     hg_branch, extra) = self.extract_hg_metadata(commit.message)
+   File "/usr/lib/pymodules/python2.6/hgext/git/git_handler.py", line 812, in 
extract_hg_metadata
+     command, data = line.split(" : ", 1)
  ValueError: need more than 1 value to unpack

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/986279

Title:
  can't clone the repo: ValueError: need more than 1 value to unpack

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/hg-git/+bug/986279/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to