(In reply to Landry Breuil from comment #115)
> So let's try to get this reviewed and hope this time it sticks. Only change
> from att 619876 is indentation fixed in Makefile.in (use tabs) and
> (defined(WTF_CPU_PPC) && !defined(JS_CPU_PPC_OSX)) for using the dummy
> cacheFlush.

You should use something else than (defined(WTF_CPU_PPC) &&
!defined(JS_CPU_PPC_OSX)), otherwise, I'll have to file yet another bug
for other platforms... I'm not convinced listing architectures is going
to be any helpful there. I think what is important is whether there is a
JIT or not. If there is no JIT, then the dummy cacheFlush works. If
there is, then there should be an actual cacheFlush implementation for
the given platform, or an explicit use of the dummy one like for
x86/x64, which don't require cache flushing.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/908508

Title:
  Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to