** Description changed: - /usr/bin/launchpad-service-status + [Impact] + The launchpad-service-status script indicates whether or not Launchpad is available. + lpltk clients use this tool to determine whether they will fail if they attempt to run. + + One of the things the tool does to achieve this is to check the + Launchpad blog for planned outages. However, if there are no planned + outages listed in the feed, the tool fails due to undefined values. + + [Development Fix] + The 2.x development series includes a fix that checks the results of the blog screenscraping before attempting to use it. This 2.0 branch is uploaded to quantal. + + [Stable Fix] + The same fix applies on the 1.x stable series, which is being proposed for precise. + + Note that with this change we're bumping the number from 0.5 to 1.0, to + indicate the package is now released and considered stable. There are + no other changes besides this bug fix. + + [Original Report] + /usr/bin/launchpad-service-status Traceback (most recent call last): - File "/usr/bin/launchpad-service-status", line 50, in <module> - if datetime.now() > outage_start and datetime.now() < outage_end: + File "/usr/bin/launchpad-service-status", line 50, in <module> + if datetime.now() > outage_start and datetime.now() < outage_end: TypeError: can't compare datetime.datetime to NoneType - A quick look at the code shows that this tool is based on screen scrapping the launchpad notification feed http://blog.launchpad.net/category/notifications/feed and is coming up empty.
** Description changed: [Impact] The launchpad-service-status script indicates whether or not Launchpad is available. lpltk clients use this tool to determine whether they will fail if they attempt to run. One of the things the tool does to achieve this is to check the Launchpad blog for planned outages. However, if there are no planned outages listed in the feed, the tool fails due to undefined values. [Development Fix] The 2.x development series includes a fix that checks the results of the blog screenscraping before attempting to use it. This 2.0 branch is uploaded to quantal. [Stable Fix] The same fix applies on the 1.x stable series, which is being proposed for precise. Note that with this change we're bumping the number from 0.5 to 1.0, to indicate the package is now released and considered stable. There are no other changes besides this bug fix. + [Test Case] + 1. Install package + 2. launchpad-service-status + + Broken Behavior: + $ launchpad-service-status + Traceback (most recent call last): + File "/usr/local/bin/launchpad-service-status", line 50, in <module> + if datetime.now() > outage_start and datetime.now() < outage_end: + TypeError: can't compare datetime.datetime to NoneType + + Fixed Behavior: + $ ./scripts/launchpad-service-status + UP READWRITE + + [Regression Potential] + None really. This just adds a check for None values before using them. + [Original Report] /usr/bin/launchpad-service-status Traceback (most recent call last): File "/usr/bin/launchpad-service-status", line 50, in <module> if datetime.now() > outage_start and datetime.now() < outage_end: TypeError: can't compare datetime.datetime to NoneType A quick look at the code shows that this tool is based on screen scrapping the launchpad notification feed http://blog.launchpad.net/category/notifications/feed and is coming up empty. ** Changed in: python-launchpadlib-toolkit (Ubuntu Quantal) Status: New => Fix Released ** Changed in: python-launchpadlib-toolkit (Ubuntu Quantal) Importance: Undecided => High ** Changed in: python-launchpadlib-toolkit (Ubuntu Precise) Importance: Undecided => High ** Changed in: python-launchpadlib-toolkit (Ubuntu Precise) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/988312 Title: launchpad-service-status can't compare datetime.datetime to NoneType To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-launchpadlib-toolkit/+bug/988312/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
