Launchpad has imported 7 comments from the remote bug at https://bugs.kde.org/show_bug.cgi?id=296401.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2012-03-19T23:47:21+00:00 Benni-i wrote: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0 Build Identifier: Gwenview leaks memory in fullscreen mode. I'm using Gwenview 2.8.1 from Kubuntu Backports ppa. Reproducible: Always Steps to Reproduce: 1. Open the first image of a directory with many (~500) high res (~12 mega pixels) images and switch to full screen 2. Switch through the images. Memory consumption will go up constantly. 3. You can speed up memory increase if you zoom every image to 100% ("F" button) Actual Results: Gwenview demands more memory than available. System is swapping. Expected Results: Gwenview should not use more memory than available. Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/0 ------------------------------------------------------------------------ On 2012-03-20T21:10:26+00:00 Benni-i wrote: I just confirmed this bug with latest git version. Disabling preloading (with exporting GWENVIEW_MAX_UNREFERENCED_IMAGES=0) seems to work around this bug. Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/1 ------------------------------------------------------------------------ On 2012-03-21T23:48:44+00:00 Benni-i wrote: Created attachment 69795 use insertMulti() I think I fixed it. The problem is that in fullscreen mode the thumbnails at the top often get loaded at the same time (< 1msec difference), so the garbageCollector sees the same mLastAccess for all images and therefore only one image is inserted into the QMap UnreferencedImages. I changed the garbageCollector to use insertMulti(). Please see attached patch and test. (IMHO overwriting the mLastAccess value by the thumbnail bar won't remove the oldest image from memory?) Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/2 ------------------------------------------------------------------------ On 2012-03-27T22:24:22+00:00 Benni-i wrote: Created attachment 69952 don't overwrite mLastAccess I found out that the mLastAccess variable is constantly overwritten in DocumentInfoProvider::isModified and DocumentInfoProvider::isBusy. I changed DocumentFactory::load(const KUrl& url) to DocumentFactory::load(const KUrl& url, bool updateLastAccess) with updateLastAccess=true as default and changed the factory->load(url) call in isModified and isBusy to factory->load(url, false). This seems to solve the problem (in an inelegant way). Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/3 ------------------------------------------------------------------------ On 2012-03-28T14:54:22+00:00 Benni-i wrote: As it seems to me that isModified and isBusy just need a pointer to an already loaded image, wouldn't it be better to implement an DocumentFactory::find(const KUrl& url) function which returns a pointer if the url has already been loaded (and hasUrl could be deprecated)? Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/4 ------------------------------------------------------------------------ On 2012-05-04T15:24:46+00:00 Aurélien Gâteau wrote: Hi, thanks for the patch! and sorry for the late answer :(. I am looking at your work right now. Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/5 ------------------------------------------------------------------------ On 2012-05-04T16:22:11+00:00 Aurélien Gâteau wrote: Git commit c2439f20fcabbde514a18389e4718b397bc0bd17 by Aurélien Gâteau. Committed on 04/05/2012 at 18:21. Pushed by gateau into branch 'KDE/4.8'. Fix leaking documents Documents were never released because DocumentInfoProvider kept loading them. A big thank you to Benni Hill for discovering the bug and proposing the initial patch. FIXED-IN:2.8.4 M +6 -11 app/documentinfoprovider.cpp M +12 -4 lib/document/documentfactory.cpp M +19 -1 lib/document/documentfactory.h http://commits.kde.org/gwenview/c2439f20fcabbde514a18389e4718b397bc0bd17 Reply at: https://bugs.launchpad.net/gwenview/+bug/999821/comments/6 ** Changed in: gwenview Status: Unknown => Fix Released ** Changed in: gwenview Importance: Unknown => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/999821 Title: gwenview has memory leak in presentation mode To manage notifications about this bug go to: https://bugs.launchpad.net/gwenview/+bug/999821/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
