v2 patch attached

> Doesn't work well with stock markers which use a custom fill color
Should be improved. Changed the logic of the color selection as below

Marker stroke color is always set to line stroke color.
Fill color :
1. If the line has fill, use that for the marker fill,
2. If the marker has no fill and no stroke assume its solid, use line stroke 
for both fill and stroke the line stroke
3. If the marker has fill color, use the marker fill color

There are also a few differences between this and the MarkerColor extension
* MarkerColor defs are not marked auto-collectable, this patch is (see comment 
#4  <bbyak> and don't forget to make such auto-copied markers auto-collectable)
* MarkerColor "name" as seen in marker list gets changed every time the color 
is updated, this patch tries to preserve the original name (original name is 
set in inkscape:stockid)

> Custom markers ... are listed, but don't stick when selected 
Should be fixed.

> Allow users to opt out of the new feature
Will add a preference for this

> Newly created custom markers are not added to list of available markers 
I will fix this is a separate patch (probably bug #903671)

> the custom template file (attached) ... not applicable in trunk+patch 
This should be fixed

** Patch added: "165865.v2.patch"
   
https://bugs.launchpad.net/inkscape/+bug/165865/+attachment/3240985/+files/165865.v2.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/165865

Title:
  markers must take object's stroke color (SVG 1.2 feature)

To manage notifications about this bug go to:
https://bugs.launchpad.net/inkscape/+bug/165865/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to