Jamie, can I ask for a reconsideration on the conditional ACK?
The two warnings:
1) "static variable should be qualified by type name": This is a code
cleanliness warning. The code should be "LZMA2Options.DICT_SIZE_MIN"
instead of "options.DICT_SIZE_MIN". Fair enough, though it doesn't
affect behavior at all.
2) "bootstrap class path not set in conjunction with -source 1.4": The
project itself specifies it works with JDK 1.4 and higher and thus
"-source 1.4" is passed to javac by default. The compiler is warning us
that it's best to also use -bootclasspath when specifying -source
because otherwise the compiler's own bootstrap classes get used, which
may not be the same as the oldest source we support. But since we
always build with the latest compiler, we don't have those classes
sitting around. And we probably don't care about maintaining 1.4
compatibility anyway.
So I don't think we should fix #2, and #1 doesn't seem worth the delta.
Eh?
** Changed in: xz-java (Ubuntu)
Assignee: Michael Terry (mterry) => Jamie Strandboge (jdstrand)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1020232
Title:
[MIR] xz-java
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xz-java/+bug/1020232/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
