Public bug reported:

If the mount option "timeo" is specified for an NFS mount in /etc/fstab,
mountall does not pass it to mount.nfs. The bug is in the function
cut_options() in mountall.c. It is called with the following arguments:

        opts = cut_options (NULL, mnt, "showthrough", "optional",
                            "bootwait", "nobootwait", "timeout",
                            NULL);

Although it should only remove the specified options, it also removes
any option that is a prefix of one of those, e.g. "timeo".

The call to strncmp() in line 661 compares only up to the length of the
option from the fstab, without comparing the length of both strings.
Hence I propose the following patch:

--- mountall-2.36/src/mountall.c.orig   2012-08-24 20:25:07.445892095 +0200
+++ mountall-2.36/src/mountall.c        2012-08-24 21:29:10.098595843 +0200
@@ -658,7 +658,8 @@
 
                va_copy (options, args);
                while ((option = va_arg (options, const char *)) != NULL)
{
-                       if (j && ! strncmp (opts + i, option, j))
+                       if (j && option[j] == '\0'
+                             && ! strncmp (opts + i, option, j))
                                break;
                }
                va_end (options);

** Affects: mountall (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1041377

Title:
  mountall ignores NFS mount option "timeo"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mountall/+bug/1041377/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to