Blockers:
* Unit tests should be working, enabled, and fail the build.  They seem to be 
disabled due to bug 1043956 currently.

Nits:
* The service should be installed into $pkglibexecdir instead of $libexecdir 
(this is an upstream issue, not a debian packaging one)
* In debian/rules, "dh_girepository -plibindicator-sync-client1" should be 
"dh_girepository -plibsync-menu1"  (alternatively, just use "--with gir" after 
the dh call to avoid overriding dh_shlibdeps at all)
* There should be a bug subscriber
* gir1.2-syncmenu-0.1 and libsync-menu-dev don't need ${shlibs:Depends}, though 
it's not hurting anything
* debian/copyright says "or later" but it shouldn't (license is GPL-3 only, not 
GPL-3+)
* Love the symbols file, but it has a lot of MISSING lines that should be 
deleted.  debian/changelog says it intentionally kept them, but I'm not sure 
why.

Comments:
* How does one play with this?  Apparently U1 doesn't use it yet?  (bug 1041358)

** Changed in: indicator-sync (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1046055

Title:
  [MIR] indicator-sync

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/indicator-sync/+bug/1046055/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to