Comment on attachment 658634
Save and restore the network proxy preference value in tests for robustness

Review of attachment 658634:
-----------------------------------------------------------------

This patch will still not allow you to connect to "localhost" when
offline, right? Just to ::1/127.0.0.1

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ -409,5 @@
>  
> -    // are we offline?
> -    bool offline = gIOService->IsOffline();
> -    if (offline)
> -        mLoadFlags |= LOAD_ONLY_FROM_CACHE;

anyway, I'm ok with this removal. just saying it's not clear that it's
the right thing.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/367531

Title:
  firefox should be smarter about offline access

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/367531/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to