Public bug reported:

on ubuntu  12.10
ii  vinagre                       3.6.0-0ubuntu1      amd64               
remote desktop client for the GNOME Desktop

when connecting to vnc which requires password authentication
vinagre will crash
this is because the usernaem inside the vinagre_tab_find_credentials_in_keyring 
function will be null

The following patch will resolve it

diff --git a/plugins/vnc/vinagre-vnc-tab.c b/plugins/vnc/vinagre-vnc-tab.c
index 10bed13..d591a29 100644
--- a/plugins/vnc/vinagre-vnc-tab.c
+++ b/plugins/vnc/vinagre-vnc-tab.c
@@ -492,7 +492,10 @@ vnc_authentication_cb (VncDisplay *vnc, GValueArray 
*credList, VinagreVncTab *vn
 
   if (need_password || need_username)
     {
-      vinagre_tab_find_credentials_in_keyring (tab, &username, &password);
+      if (vinagre_connection_get_username (conn) != NULL)
+        {
+          vinagre_tab_find_credentials_in_keyring (tab, &username, &password);
+        }
       if ( (need_username && !username) || (need_password && !password) )
        {
          host = vinagre_connection_get_best_name (conn);

** Affects: vinagre (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1071055

Title:
  vinagre crashed on connecting to vnc

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/vinagre/+bug/1071055/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to