** Branch linked: lp:ubuntu/raring-proposed/rsyslog

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1075901

Title:
  Incorrect ownership or permissions for spool/work directory

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1075901/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

From [email protected] Mon Nov 12 04:30:50 2012
Return-path: <[email protected]>
Envelope-to: [email protected]
Delivery-date: Mon, 12 Nov 2012 04:30:50 -0800
Received: from exprod5mx249.postini.com ([64.18.0.169] helo=psmtp.com)
        by mail-archive.com with smtp (Exim 4.69)
        (envelope-from <[email protected]>)
        id 1TXtAA-0000cd-8I
        for [email protected]; Mon, 12 Nov 2012 04:30:50 -0800
Received: from vger.kernel.org ([209.132.180.67]) by exprod5mx249.postini.com 
([64.18.4.10]) with SMTP;
        Mon, 12 Nov 2012 07:30:48 EST
Received: ([email protected]) by vger.kernel.org via listexpand
        id S1751685Ab2KLMa2 (ORCPT <rfc822;[email protected]>);
        Mon, 12 Nov 2012 07:30:28 -0500
Received: from mail-vc0-f174.google.com ([209.85.220.174]:39636 "EHLO
        mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751337Ab2KLMa0 convert rfc822-to-8bit (ORCPT
        <rfc822;[email protected]>);
        Mon, 12 Nov 2012 07:30:26 -0500
Received: by mail-vc0-f174.google.com with SMTP id fk26so6031062vcb.19
        for <multiple recipients>; Mon, 12 Nov 2012 04:30:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=TKfEA6y8Fp4NJdPkf633dGRXV2DuUksMG+lZknebquc=;
        b=sHRDvoqajeDh2ul/v/pkERCvJHS4QVcB4oV8bERv6tFAUUjXjIpMTKyyciihAZKJi0
         HgCMS8TQpcAGq3FEqOnSqlcIkdH2f9Ar2ANIkD4FjXSCA7H9i0lbmIJXwCrvBXUqwr8Y
         s53Xs437ugvYr7YXhQxwd41x5Q91/Aa72gvHhKE9+HqpAXRKb4F6+kQ933PQjatl6ocH
         YKpNp11m+BQpDXJGg4moIrR+a0avanVF4QKxox5MeOfiNa1mMqRPHC5731JYJPx6Cbis
         GMdqj/+Phn/H7SIpZpL30AKiqjezGAHzMDhNLQ879iiq4GRLGA04nvOtMSUm5vysO9Yy
         hJ+w==
MIME-Version: 1.0
Received: by 10.58.74.196 with SMTP id w4mr19557507vev.7.1352723425286; Mon,
 12 Nov 2012 04:30:25 -0800 (PST)
Received: by 10.58.163.166 with HTTP; Mon, 12 Nov 2012 04:30:25 -0800 (PST)
In-Reply-To: <[email protected]>
References: <[email protected]>
        <camuhmduew9k6cfpcunphte_vzbcl_oa_od3892dq3qbx5xm...@mail.gmail.com>
        <[email protected]>
Date:   Mon, 12 Nov 2012 13:30:25 +0100
X-Google-Sender-Auth: g_Yzqtu9cdkNCiyCaijYLNWiMcA
Message-ID: <camuhmdwq9s9oo+2oh6oiaogfr+jjxnxrtgomp+umm-qxclr...@mail.gmail.com>
Subject: Re: [PATCH] HID: microsoft, do not use compound literal
From:   Geert Uytterhoeven <[email protected]>
To:     Jiri Kosina <[email protected]>
Cc:     Jiri Slaby <[email protected]>, [email protected],
        [email protected], [email protected]
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: [email protected]
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: [email protected]
X-pstn-neptune: 6/2/0.33/99
X-pstn-levels:     (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 
R:95.9108 P:95.9108 M:97.0282 C:98.6951 )
X-pstn-dkim: 1 skipped:not-enabled
X-pstn-settings: 4 (1.5000:1.5000) s cv gt3 gt2 gt1 r p m c 
X-pstn-addresses: from <[email protected]> [294/10] 

On Mon, Nov 12, 2012 at 1:15 PM, Jiri Kosina <[email protected]> wrote:
> On Mon, 12 Nov 2012, Geert Uytterhoeven wrote:
>> On Mon, Nov 12, 2012 at 10:16 AM, Jiri Slaby <[email protected]> wrote:
>> > In patch "HID: microsoft: fix invalid rdesc for 3k kbd" I fixed
>> > support for MS 3k keyboards. However the added check using memcmp and
>> > a compound statement breaks build on architectures where memcmp is a
>> > macro with parameters. The error looks there like (m68k-linux-gnu-gcc
>> > 4.1.2):
>> > hid-microsoft.c:51:18: error: macro "memcmp" passed 6 arguments, but takes 
>> > just 3
>> > hid-microsoft.c: In function ‘ms_report_fixup’:
>> > drivers/hid/hid-microsoft.c:50: error: ‘memcmp’ undeclared (first use 
>> > in this function)
>> > hid-microsoft.c:50: error: (Each undeclared identifier is reported only 
>> > once
>> > /hid-microsoft.c:50: error: for each function it appears in.)
>>
>> The above 3 lines were actually from a build with a different config
>> --- which I didn't
>> notice at that time --- where <linux/string.h> was not indirectly included.
>
> Still the patch needs string.h include addition, otherwise you still are
> able to come up with m68k config that doesn't build, do I understand it
> correctly?

No.

My comment was purely cosmetic, as it applies to the quoted compiler error
messages only.

Your latest version doesn't use memcmp() anymore, so I think there's no need to
include <linux/string.h> anymore.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to