(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > @Markus Mohrhard:
> > > I'd love to whenever the update is downstreamed into Ubuntu repositories.
> > > 
> > > Q: How can such a regression happen? Any ideas or explanations?
> > 
> > Calc has about 1 million lines of own source code + several more million
> > lines of shared source code. And how much time did you spend yourself
> > testing master to check for regressions.
> > 
> > Marking as fixed as I think it is fixed in 3.6.4.1 and therefore in the
> > 3.6.4 release. Reopen if it is not fixed there.
> 
> First I am pretty sure that not all of the 1 million lines deal with
> sorting. Second, in my development projects we used test suites to prevent
> from regression and third there are statistical methods to identify areas of
> unstable code based on previous bug reports.

We have highly coupled code with to less test code. Sadly our code is so
old and written by so many people that even simple tasks like sorting
affect more places than it should. For example sorting is highly
integrated into calc core in ScTable so that a change to fix another bug
can introduce a new one in parts that nobody expects.

We are writing new tests for fixed bugs but since we are mainly only
three developers doing all the work on calc this means that there are
thousand of untested cases. However we are always happy if someone helps
us out with extending the test cases which is actually not that
difficult.

> 
> Assuming that all this is in place here as well, I was wondering what could
> be the cause of those regressions. If you had an idea I could direct some
> research effort into how this can be improved. Maybe we can discuss this on
> a different channel (mail?)

We were removing some limitations for sorting in 3.6 and therefore had
to change some internal data structure and change the UI code. This was
done by a volunteer and sadly not enough tests were written at the time.
I would be very glad if you would be intersted in helping with that.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1082449

Title:
  [Upstream] Calc mis-sorts left to right (sort columns)

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1082449/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to