Patch for precise SRU.

** Patch added: "lp787736.patch"
   
https://bugs.launchpad.net/ubuntu/+source/appmenu-gtk/+bug/787736/+attachment/3446176/+files/lp787736.patch

** Description changed:

+ [Impact]
+ This issue affects most and any users of appgtk-menu, such as nm-applet, 
especially in environments (such as offices) where the detected wireless 
networks change a lot, and where roaming can occur frequently. See also: LP: 
#780602
+ 
+ [Test Case]
+ Run nm-applet for multiple hours:
+  - Observe that the VPN Connections submenu still opens and lists connections 
(if VPN connections are configured)
+  - Observe that the "More networks" submenu for additional detected wireless 
networks still opens and lists networks.
+ 
+ A common failure case is where such a submenu will open but show an
+ empty list (a piece of menu a few milimeters long).
+ 
+ [Regression Potential]
+ Minimal, the fixes have been available for a while in the development release 
(and in other recent releases) with no regressions.
+ Possible issues could be introducing new memory leaks with the changes 
however, and although the risk is minimal, this could cause the same failure 
behavior as listed above under [Test Case].
+ 
+ --
+ 
  Binary package hint: appmenu-gtk
  
  The rebuild function creates a hash table mapping the toplevel to the
  g_timeout id responsible for doing the refresh.
  
  The rebuild function allocates a RebuildData object to pass to the
  do_rebuild idle function. The do_rebuild callback function frees this
  object when it is called.
  
  However, the do_rebuild function isn't guaranteed to be called. In fact
  the whole point of the hash table seems to be that the callback can be
  canceled. When that happens, the RebuildData object isn't freed, causing
  a leak.
  
  Additionally, instead of storing a proper reference to the toplevel in
  the RebuldData object, a weak pointer is stored instead. But if the weak
  pointer gets set to null, the do_rebuld function will lose its only copy
  of that pointer, so it will have no way of cleaning up the associated
  entry in the hash table.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/787736

Title:
  RebuildData structs are leaked in rebuild() / do_rebuild()

To manage notifications about this bug go to:
https://bugs.launchpad.net/appmenu-gtk/+bug/787736/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to