On Wed, 2013-01-09 at 15:32 +0000, Sebastien Bacher wrote: > I've sponsored the uploads, some comments from the NEW review from > didrocks: > > - should the binary have a python depends?
It shouldn't. > - what's the point of the override_dh_auto_install in debian/rules? the > rm on debian/tmp/... doesn't make sense, if there is only one binary the > make install is done in debian/<binary> and not debian/tmp ... is that a > leftover copy from another source? This is to remove the .egg-info from the python dir, as there is no actual Python code, and we are simply using setup.py to install data at this time. I didn't notice it wasn't working right (there's also no lintian error/warning about it, and perhaps should be), so I can change this. > - is there any reason to not set the compat to 9? We still need to support older versions of Ubuntu, which don't have newer debhelper, and it's easier to do so if we can use the same debian/ contents for all our supported versions. Though, when 13.04 is released (and 10.04 and 11.10 are EOL), we can certainly change all our packages to set compat to 9. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1047606 Title: [needs-packaging] ubuntuone-client-data To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1047606/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
