At Tue, 12 Feb 2013 10:16:13 +0100, David Henningsson wrote: > > On 02/12/2013 10:10 AM, Takashi Iwai wrote: > > At Tue, 12 Feb 2013 10:06:11 +0100, > > David Henningsson wrote: > >> > >> This is needed by snd_pcm_format_silence* functions which > >> return u_int*_t. It was discovered while trying to compile ALSA > >> programs with eglibc 2.17. > >> > >> Credits to Richard Shaw, Gary Buhrmaster, Matthieu Baerts and > >> Adam Conrad for this fix. > >> > >> BugLink: https://bugs.launchpad.net/bugs/1109298 > >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=885306 > >> Signed-off-by: David Henningsson <david.hennings...@canonical.com> > > > > For u_int_* types, wouldn't it better to include stdint.h? > > Hmm, it looks like stdint.h declares uint_* whereas sys/types.h declares > u_int_* (notice the _ between "u" and "int"). Do you think we should > change snd_pcm_format_silence* from u_int to uint?
Ah, OK, then sys/types.h is the right inclusion. Maybe conversion to uint_*_t would be more universal, but I don't think it's worth, as these types are used in many places in the public API already. I'll take your patch as is now. thanks, Takashi -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1109298 Title: [Regression] error when trying to compile a program which uses alsa/asoundlib.h with EGLIBC 2.17 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/alsa-lib/+bug/1109298/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
