I looked at it, some comments:

* "freq-data/getcorpus.cpp: LGPL (v3 or later)
  [Copyright: 2013 Ben Au <benau2006 at yahoo dot com dot hk>]

freq-data/countfreq.sh: LGPL (v3 or later)
  [Copyright: 2013 Ben Au <benau2006 at yahoo dot com dot hk>]"

the copyright holder there should be listed in debian/copyright

* freq-data/quick-classic.txt is under GPL according to
debian/copyright, shouldn't the GPL be shipped in the tarball (as
COPYING.GPL or similar)?

* debian/rules:
DEB_HOST_MULTIARCH  ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

seems weird, can't you just bump compat to 9 and let dh do its magic?

* debian/control:
- why do you "Pre-Depends: multiarch-support" if you don't use Multi-Arch: 
same/foreign tags? is the library supposed to be multiarched?
- Standard-Versions current is 3.9.4
- would be nice to wrap build-depends/depends with one items by line, it makes 
diff easier to read over time


Otherwise it seems fine, I'm not sure any of those is a blocker for upload. Do 
you need a sponsor for Ubuntu upload?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1154197

Title:
  [FFe] [needs packaging] New package libcangjie

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1154197/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to